mirror of
https://github.com/django/django.git
synced 2025-10-31 09:41:08 +00:00
Fixed #10043 -- widthratio tag now accepts a variable for the max_width argument.
The max_width argument now passes through FilterExpression which by side-affect allows float values, but will be truncated. Thanks obeattie and Eric Holscher for patches. git-svn-id: http://code.djangoproject.com/svn/django/trunk@10352 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
@@ -402,12 +402,15 @@ class WidthRatioNode(Node):
|
||||
try:
|
||||
value = self.val_expr.resolve(context)
|
||||
maxvalue = self.max_expr.resolve(context)
|
||||
max_width = int(self.max_width.resolve(context))
|
||||
except VariableDoesNotExist:
|
||||
return ''
|
||||
except ValueError:
|
||||
raise TemplateSyntaxError("widthratio final argument must be an number")
|
||||
try:
|
||||
value = float(value)
|
||||
maxvalue = float(maxvalue)
|
||||
ratio = (value / maxvalue) * int(self.max_width)
|
||||
ratio = (value / maxvalue) * max_width
|
||||
except (ValueError, ZeroDivisionError):
|
||||
return ''
|
||||
return str(int(round(ratio)))
|
||||
@@ -1143,12 +1146,10 @@ def widthratio(parser, token):
|
||||
if len(bits) != 4:
|
||||
raise TemplateSyntaxError("widthratio takes three arguments")
|
||||
tag, this_value_expr, max_value_expr, max_width = bits
|
||||
try:
|
||||
max_width = int(max_width)
|
||||
except ValueError:
|
||||
raise TemplateSyntaxError("widthratio final argument must be an integer")
|
||||
|
||||
return WidthRatioNode(parser.compile_filter(this_value_expr),
|
||||
parser.compile_filter(max_value_expr), max_width)
|
||||
parser.compile_filter(max_value_expr),
|
||||
parser.compile_filter(max_width))
|
||||
widthratio = register.tag(widthratio)
|
||||
|
||||
#@register.tag
|
||||
|
||||
Reference in New Issue
Block a user