From 630eb0564abd228da439d86ad93acb4089d795e7 Mon Sep 17 00:00:00 2001 From: Andrew Godwin Date: Fri, 6 Sep 2013 11:09:16 -0500 Subject: [PATCH] Fix SchemaEditor.__exit__ to handle exceptions correctly --- django/db/backends/schema.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/django/db/backends/schema.py b/django/db/backends/schema.py index eac7364b11..3b1db33fe1 100644 --- a/django/db/backends/schema.py +++ b/django/db/backends/schema.py @@ -74,10 +74,7 @@ class BaseDatabaseSchemaEditor(object): if exc_type is None: for sql in self.deferred_sql: self.execute(sql) - atomic(self.connection.alias, self.connection.features.can_rollback_ddl).__exit__(None, None, None) - else: - # Continue propagating exception - return None + atomic(self.connection.alias, self.connection.features.can_rollback_ddl).__exit__(exc_type, exc_value, traceback) # Core utility functions