mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-01-08 17:37:20 +00:00
Code Issues 32 Releases Wiki Activity

Refs #27859 -- Refactored BaseDatabaseValidation to use check_field_type().

Browse Source 
Thanks Tim Graham for the review.
This commit is contained in:
Mariusz Felisiak 2017-05-14 18:34:45 +02:00 committed by GitHub
parent 680968b9e4
commit 5cff2cb4c0
2 changed files with 18 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
django/db/backends/base/validation.py
View File

@ -7,4 +7,19 @@ class BaseDatabaseValidation:
return []
def check_field(self, field, **kwargs):
return []
errors = []
# Backends may implement a check_field_type() method.
if (hasattr(self, 'check_field_type') and
# Ignore any related fields.
not getattr(field, 'remote_field', None)):
# Ignore fields with unsupported features.
db_supports_all_required_features = all(
getattr(self.connection.features, feature, False)
for feature in field.model._meta.required_db_features
)
if db_supports_all_required_features:
field_type = field.db_type(self.connection)
# Ignore non-concrete fields.
if field_type is not None:
errors.extend(self.check_field_type(field, field_type))
return errors

23
django/db/backends/mysql/validation.py
View File

@ -26,32 +26,13 @@ class DatabaseValidation(BaseDatabaseValidation):
)]
return []
def check_field(self, field, **kwargs):
def check_field_type(self, field, field_type):
"""
MySQL has the following field length restriction:
No character (varchar) fields can have a length exceeding 255
characters if they have a unique index on them.
"""
errors = super().check_field(field, **kwargs)
# Ignore any related fields.
if getattr(field, 'remote_field', None):
return errors
# Ignore fields with unsupported features.
db_supports_all_required_features = all(
getattr(self.connection.features, feature, False)
for feature in field.model._meta.required_db_features
)
if not db_supports_all_required_features:
return errors
field_type = field.db_type(self.connection)
# Ignore non-concrete fields.
if field_type is None:
return errors
errors = []
if (field_type.startswith('varchar') and field.unique and
(field.max_length is None or int(field.max_length) > 255)):
errors.append(