From 5b8699e723d9daf373fff46c6859fed2b780a9bd Mon Sep 17 00:00:00 2001 From: Aymeric Augustin Date: Sat, 16 Apr 2022 18:53:46 +0200 Subject: [PATCH] Renamed LogoutView.get_next_page() to get_success_url(). This aligns it with LoginView. Also, it removes confusion with the get_next_page() method of paginators. get_next_page() was a private API, therefore this refactoring is allowed. --- django/contrib/auth/views.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/django/contrib/auth/views.py b/django/contrib/auth/views.py index fa6f4f4cc4..25d987d0dc 100644 --- a/django/contrib/auth/views.py +++ b/django/contrib/auth/views.py @@ -142,16 +142,16 @@ class LogoutView(RedirectURLMixin, TemplateView): def post(self, request, *args, **kwargs): """Logout may be done via POST.""" auth_logout(request) - next_page = self.get_next_page() - if next_page: + redirect_to = self.get_success_url() + if redirect_to: # Redirect to this page until the session has been cleared. - return HttpResponseRedirect(next_page) + return HttpResponseRedirect(redirect_to) return super().get(request, *args, **kwargs) # RemovedInDjango50Warning. get = post - def get_next_page(self): + def get_success_url(self): if self.next_page is not None: next_page = resolve_url(self.next_page) elif settings.LOGOUT_REDIRECT_URL: