1
0
mirror of https://github.com/django/django.git synced 2024-12-23 01:25:58 +00:00

Fixed #27922 -- Added ErrorDict.get_json_data().

This commit is contained in:
Tim Heap 2017-03-10 10:45:50 +11:00 committed by Tim Graham
parent 2f09a28558
commit 5b6181f4d5
4 changed files with 30 additions and 4 deletions

View File

@ -51,8 +51,11 @@ class ErrorDict(dict):
def as_data(self):
return {f: e.as_data() for f, e in self.items()}
def get_json_data(self, escape_html=False):
return {f: e.get_json_data(escape_html) for f, e in self.items()}
def as_json(self, escape_html=False):
return json.dumps({f: e.get_json_data(escape_html) for f, e in self.items()})
return json.dumps(self.get_json_data(escape_html))
def as_ul(self):
if not self:

View File

@ -165,6 +165,17 @@ If for some reason you don't want to use client-side escaping, you can also
set ``escape_html=True`` and error messages will be escaped so you can use them
directly in HTML.
.. method:: Form.errors.get_json_data(escape_html=False)
.. versionadded:: 2.0
Returns the errors as a dictionary suitable for serializing to JSON.
:meth:`Form.errors.as_json()` returns serialized JSON, while this returns the
error data before it's serialized.
The ``escape_html`` parameter behaves as described in
:meth:`Form.errors.as_json()`.
.. method:: Form.add_error(field, error)
This method allows adding errors to specific fields from within the

View File

@ -166,6 +166,10 @@ Forms
HTML attributes for the ``DateInput`` and ``TimeInput`` (or hidden)
subwidgets.
* The new :meth:`Form.errors.get_json_data()
<django.forms.Form.errors.get_json_data>` method returns form errors as
a dictionary suitable for including in a JSON response.
Generic Views
~~~~~~~~~~~~~

View File

@ -3216,13 +3216,14 @@ Good luck picking a username that doesn&#39;t already exist.</p>
for error in control:
self.assertInHTML(error, errors)
errors = json.loads(form.errors.as_json())
errors = form.errors.get_json_data()
control = {
'foo': [{'code': 'required', 'message': 'This field is required.'}],
'bar': [{'code': 'required', 'message': 'This field is required.'}],
'__all__': [{'code': 'secret', 'message': 'Non-field error.'}]
}
self.assertEqual(errors, control)
self.assertEqual(json.dumps(errors), form.errors.as_json())
def test_error_dict_as_json_escape_html(self):
"""#21962 - adding html escape flag to ErrorDict"""
@ -3247,8 +3248,13 @@ Good luck picking a username that doesn&#39;t already exist.</p>
errors = json.loads(form.errors.as_json())
self.assertEqual(errors, control)
escaped_error = '&lt;p&gt;Non-field error.&lt;/p&gt;'
self.assertEqual(
form.errors.get_json_data(escape_html=True)['__all__'][0]['message'],
escaped_error
)
errors = json.loads(form.errors.as_json(escape_html=True))
control['__all__'][0]['message'] = '&lt;p&gt;Non-field error.&lt;/p&gt;'
control['__all__'][0]['message'] = escaped_error
self.assertEqual(errors, control)
def test_error_list(self):
@ -3270,10 +3276,12 @@ Good luck picking a username that doesn&#39;t already exist.</p>
'<ul class="errorlist"><li>Foo</li><li>Foobar</li></ul>'
)
errors = e.get_json_data()
self.assertEqual(
json.loads(e.as_json()),
errors,
[{"message": "Foo", "code": ""}, {"message": "Foobar", "code": "foobar"}]
)
self.assertEqual(json.dumps(errors), e.as_json())
def test_error_list_class_not_specified(self):
e = ErrorList()