From 5a3d7cf46205f42303a5f429c388cb507ef5d630 Mon Sep 17 00:00:00 2001 From: Jon Dufresne Date: Thu, 9 Jul 2020 03:03:03 -0700 Subject: [PATCH] Used urllib.parse.urljoin() in auth_tests to join URLs. As the strings represent URLs and not paths, should use urllib to manipulate them. --- tests/auth_tests/test_views.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/auth_tests/test_views.py b/tests/auth_tests/test_views.py index 2f27fa7271..bb887e49ea 100644 --- a/tests/auth_tests/test_views.py +++ b/tests/auth_tests/test_views.py @@ -1,10 +1,9 @@ import datetime import itertools -import os import re from importlib import import_module from unittest import mock -from urllib.parse import quote +from urllib.parse import quote, urljoin from django.apps import apps from django.conf import settings @@ -1216,10 +1215,7 @@ class ChangelistTests(AuthViewsTestCase): r'you can change the password using this form', response.content.decode() )[1] - self.assertEqual( - os.path.normpath(user_change_url + rel_link), - os.path.normpath(password_change_url) - ) + self.assertEqual(urljoin(user_change_url, rel_link), password_change_url) response = self.client.post( password_change_url,