mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-06-24 04:49:11 +00:00
Code Issues 32 Releases Wiki Activity

Refs #35038 -- Reduced CreateModel/AlterConstraint operations when optimizing migrations.

Browse Source
This commit is contained in:
Jacob Walls 2025-06-19 06:22:23 -04:00 committed by GitHub
parent bc1bfe12b6
commit 56f468681a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 63 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
django/db/migrations/operations/models.py
View File

@ -346,6 +346,21 @@ class CreateModel(ModelOperation):
}, },
), ),
] ]
elif isinstance(operation, AlterConstraint):
options_constraints = [
constraint
for constraint in self.options.get("constraints", [])
if constraint.name != operation.name
] + [operation.constraint]
return [
replace(
self,
options={
**self.options,
"constraints": options_constraints,
},
),
]
elif isinstance(operation, RemoveConstraint): elif isinstance(operation, RemoveConstraint):
options_constraints = [ options_constraints = [
constraint constraint

48
tests/migrations/test_optimizer.py
View File

@ -1434,6 +1434,54 @@ class OptimizerTests(OptimizerTestBase):
], ],
) )
def test_create_model_alter_constraint(self):
original_constraint = models.CheckConstraint(
condition=models.Q(weight__gt=0), name="pony_weight_gt_0"
)
altered_constraint = models.CheckConstraint(
condition=models.Q(weight__gt=0),
name="pony_weight_gt_0",
violation_error_message="incorrect weight",
)
self.assertOptimizesTo(
[
migrations.CreateModel(
name="Pony",
fields=[
("weight", models.IntegerField()),
],
options={
"constraints": [
original_constraint,
models.UniqueConstraint(
"weight", name="pony_weight_unique"
),
],
},
),
migrations.AlterConstraint(
"Pony", "pony_weight_gt_0", altered_constraint
),
],
[
migrations.CreateModel(
name="Pony",
fields=[
("weight", models.IntegerField()),
],
options={
"constraints": [
models.UniqueConstraint(
"weight",
name="pony_weight_unique",
),
altered_constraint,
]
},
),
],
)
def test_create_model_remove_constraint(self): def test_create_model_remove_constraint(self):
self.assertOptimizesTo( self.assertOptimizesTo(
[ [