1
0
mirror of https://github.com/django/django.git synced 2025-10-24 06:06:09 +00:00

Fixed #27818 -- Replaced try/except/pass with contextlib.suppress().

This commit is contained in:
Mads Jensen
2017-03-09 16:17:41 +01:00
committed by Tim Graham
parent 43a4835edf
commit 550cb3a365
67 changed files with 223 additions and 368 deletions

View File

@@ -1,4 +1,5 @@
import json
from contextlib import suppress
from django.db.models.expressions import F, Value
from django.test.testcases import skipUnlessDBFeature
@@ -7,14 +8,12 @@ from django.test.utils import Approximate
from . import PostgreSQLTestCase
from .models import AggregateTestModel, StatTestModel
try:
with suppress(ImportError): # psycopg2 is not installed
from django.contrib.postgres.aggregates import (
ArrayAgg, BitAnd, BitOr, BoolAnd, BoolOr, Corr, CovarPop, JSONBAgg,
RegrAvgX, RegrAvgY, RegrCount, RegrIntercept, RegrR2, RegrSlope,
RegrSXX, RegrSXY, RegrSYY, StatAggregate, StringAgg,
)
except ImportError:
pass # psycopg2 is not installed
class TestGeneralAggregate(PostgreSQLTestCase):

View File

@@ -2,6 +2,7 @@ import decimal
import json
import unittest
import uuid
from contextlib import suppress
from django import forms
from django.core import exceptions, serializers, validators
@@ -19,13 +20,11 @@ from .models import (
PostgreSQLModel, Tag,
)
try:
with suppress(ImportError):
from django.contrib.postgres.fields import ArrayField
from django.contrib.postgres.forms import (
SimpleArrayField, SplitArrayField, SplitArrayWidget,
)
except ImportError:
pass
class TestSaveLoad(PostgreSQLTestCase):

View File

@@ -1,4 +1,5 @@
import json
from contextlib import suppress
from django.core import exceptions, serializers
from django.forms import Form
@@ -7,12 +8,10 @@ from django.test.utils import modify_settings
from . import PostgreSQLTestCase
from .models import HStoreModel
try:
with suppress(ImportError):
from django.contrib.postgres import forms
from django.contrib.postgres.fields import HStoreField
from django.contrib.postgres.validators import KeysValidator
except ImportError:
pass
@modify_settings(INSTALLED_APPS={'append': 'django.contrib.postgres'})

View File

@@ -1,5 +1,6 @@
import datetime
import uuid
from contextlib import suppress
from decimal import Decimal
from django.core import exceptions, serializers
@@ -11,11 +12,9 @@ from django.utils.html import escape
from . import PostgreSQLTestCase
from .models import JSONModel
try:
with suppress(ImportError):
from django.contrib.postgres import forms
from django.contrib.postgres.fields import JSONField
except ImportError:
pass
@skipUnlessDBFeature('has_jsonb_datatype')

View File

@@ -1,5 +1,6 @@
import datetime
import json
from contextlib import suppress
from django import forms
from django.core import exceptions, serializers
@@ -10,14 +11,12 @@ from django.utils import timezone
from . import PostgreSQLTestCase
from .models import RangeLookupsModel, RangesModel
try:
with suppress(ImportError):
from psycopg2.extras import DateRange, DateTimeTZRange, NumericRange
from django.contrib.postgres import fields as pg_fields, forms as pg_forms
from django.contrib.postgres.validators import (
RangeMaxValueValidator, RangeMinValueValidator,
)
except ImportError:
pass
class TestSaveLoad(PostgreSQLTestCase):