From 54402a75296909b1b00df41ff4dbd95e3d8a87e6 Mon Sep 17 00:00:00 2001 From: Tim Graham Date: Sat, 21 Jun 2025 08:51:34 -0400 Subject: [PATCH] Removed @skipIfDBFeature silencing of nonexistent features. Follow up to f5df7ed7e62585c7d0289a88a327dab8d608efcf. --- django/test/testcases.py | 4 +--- tests/test_utils/tests.py | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/django/test/testcases.py b/django/test/testcases.py index 37529603be..d4d61c8fba 100644 --- a/django/test/testcases.py +++ b/django/test/testcases.py @@ -1582,9 +1582,7 @@ def _deferredSkip(condition, reason, name): def skipIfDBFeature(*features): """Skip a test if a database has at least one of the named features.""" return _deferredSkip( - lambda: any( - getattr(connection.features, feature, False) for feature in features - ), + lambda: any(getattr(connection.features, feature) for feature in features), "Database has feature(s) %s" % ", ".join(features), "skipIfDBFeature", ) diff --git a/tests/test_utils/tests.py b/tests/test_utils/tests.py index fa2bee7870..494a0ea8d3 100644 --- a/tests/test_utils/tests.py +++ b/tests/test_utils/tests.py @@ -133,10 +133,10 @@ class SkippingTestCase(SimpleTestCase): raise ValueError self._assert_skipping(test_func, unittest.SkipTest) - self._assert_skipping(test_func2, ValueError) + self._assert_skipping(test_func2, AttributeError) self._assert_skipping(test_func3, unittest.SkipTest) self._assert_skipping(test_func4, unittest.SkipTest) - self._assert_skipping(test_func5, ValueError) + self._assert_skipping(test_func5, AttributeError) class SkipTestCase(SimpleTestCase): @skipIfDBFeature("missing")