mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 09:41:08 +00:00
Code Issues 32 Releases Wiki Activity

[2.0.x] Fixed #28679 -- Fixed urlencode()'s handling of bytes.

Browse Source 
Regression in fee42fd99e.

Thanks Claude Paroz, Jon Dufresne, and Tim Graham for the guidance.

Backport of 41be85862d from master
This commit is contained in:
François Freitag
2017-10-09 13:20:01 -07:00
committed by Tim Graham
parent 2a55063dcc
commit 51998a2988
2 changed files with 35 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/utils_tests/test_http.py
View File

@@ -49,6 +49,23 @@ class URLEncodeTests(unittest.TestCase):
'position=Developer&name=Adrian&name=Simon',
])
def test_dict_with_bytes_values(self):
self.assertEqual(urlencode({'a': b'abc'}, doseq=True), 'a=abc')
def test_dict_with_sequence_of_bytes(self):
self.assertEqual(urlencode({'a': [b'spam', b'eggs', b'bacon']}, doseq=True), 'a=spam&a=eggs&a=bacon')
def test_dict_with_bytearray(self):
self.assertEqual(urlencode({'a': bytearray(range(2))}, doseq=True), 'a=0&a=1')
self.assertEqual(urlencode({'a': bytearray(range(2))}, doseq=False), 'a=%5B%270%27%2C+%271%27%5D')
def test_generator(self):
def gen():
yield from range(2)
self.assertEqual(urlencode({'a': gen()}, doseq=True), 'a=0&a=1')
self.assertEqual(urlencode({'a': gen()}, doseq=False), 'a=%5B%270%27%2C+%271%27%5D')
class Base36IntTests(SimpleTestCase):
def test_roundtrip(self):