mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-06-05 11:39:13 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #20806 -- Cached loader caches find_template

Browse Source 
The cached template loader should cache find_template in addition to
load_template.
This commit is contained in:
Gavin Wahl 2013-07-25 13:27:23 -06:00 committed by Tim Graham
parent 3c45fb8589
commit 5154c9f92c
1 changed files with 27 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
django/template/loaders/cached.py
View File

@ -13,6 +13,7 @@ class Loader(BaseLoader):
def __init__(self, loaders): def __init__(self, loaders):
self.template_cache = {} self.template_cache = {}
self.find_template_cache = {}
self._loaders = loaders self._loaders = loaders
self._cached_loaders = [] self._cached_loaders = []
@ -28,21 +29,34 @@ class Loader(BaseLoader):
self._cached_loaders = cached_loaders self._cached_loaders = cached_loaders
return self._cached_loaders return self._cached_loaders
def find_template(self, name, dirs=None): def cache_key(self, template_name, template_dirs):
for loader in self.loaders:
try:
template, display_name = loader(name, dirs)
return (template, make_origin(display_name, loader, name, dirs))
except TemplateDoesNotExist:
pass
raise TemplateDoesNotExist(name)
def load_template(self, template_name, template_dirs=None):
key = template_name
if template_dirs: if template_dirs:
# If template directories were specified, use a hash to differentiate # If template directories were specified, use a hash to differentiate
key = '-'.join([template_name, hashlib.sha1(force_bytes('|'.join(template_dirs))).hexdigest()]) return '-'.join([template_name, hashlib.sha1(force_bytes('|'.join(template_dirs))).hexdigest()])
else:
return template_name
def find_template(self, name, dirs=None):
key = self.cache_key(name, dirs)
try:
result = self.find_template_cache[key]
except KeyError:
result = None
for loader in self.loaders:
try:
template, display_name = loader(name, dirs)
except TemplateDoesNotExist:
pass
else:
result = (template, make_origin(display_name, loader, name, dirs))
self.find_template_cache[key] = result
if result:
return result
else:
raise TemplateDoesNotExist(name)
def load_template(self, template_name, template_dirs=None):
key = self.cache_key(template_name, template_dirs)
try: try:
template = self.template_cache[key] template = self.template_cache[key]
except KeyError: except KeyError:
@ -62,3 +76,4 @@ class Loader(BaseLoader):
def reset(self): def reset(self):
"Empty the template cache." "Empty the template cache."
self.template_cache.clear() self.template_cache.clear()
self.find_template_cache.clear()