1
0
mirror of https://github.com/django/django.git synced 2025-10-24 14:16:09 +00:00

Refs #26601 -- Deprecated passing None as get_response arg to middleware classes.

This is the new contract since middleware refactoring in Django 1.10.

Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
This commit is contained in:
Claude Paroz
2019-09-26 19:06:35 +02:00
committed by Carlton Gibson
parent a34cb5a6d4
commit 4d973f5939
23 changed files with 668 additions and 502 deletions

View File

@@ -1,5 +1,6 @@
from django.conf import settings
from django.core.exceptions import MiddlewareNotUsed
from django.http import HttpResponse
from django.test import RequestFactory, SimpleTestCase, override_settings
from . import middleware as mw
@@ -114,7 +115,7 @@ class RootUrlconfTests(SimpleTestCase):
class MyMiddleware:
def __init__(self, get_response=None):
def __init__(self, get_response):
raise MiddlewareNotUsed
def process_request(self, request):
@@ -123,7 +124,7 @@ class MyMiddleware:
class MyMiddlewareWithExceptionMessage:
def __init__(self, get_response=None):
def __init__(self, get_response):
raise MiddlewareNotUsed('spam eggs')
def process_request(self, request):
@@ -142,7 +143,7 @@ class MiddlewareNotUsedTests(SimpleTestCase):
def test_raise_exception(self):
request = self.rf.get('middleware_exceptions/view/')
with self.assertRaises(MiddlewareNotUsed):
MyMiddleware().process_request(request)
MyMiddleware(lambda req: HttpResponse()).process_request(request)
@override_settings(MIDDLEWARE=['middleware_exceptions.tests.MyMiddleware'])
def test_log(self):