mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-24 22:26:08 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #34333 -- Fixed migration operations ordering when adding index/constraint on new foreign key.

Browse Source 
Thanks Simon Charette and David Wobrock for reviews.
This commit is contained in:
Durval Carvalho
2023-03-07 17:00:28 -03:00
committed by Mariusz Felisiak
parent dde2537fbb
commit 4b1bfea284
2 changed files with 79 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
django/db/migrations/autodetector.py
View File

@@ -1304,6 +1304,7 @@ class MigrationAutodetector:
def generate_added_indexes(self):
for (app_label, model_name), alt_indexes in self.altered_indexes.items():
dependencies = self._get_dependencies_for_model(app_label, model_name)
for index in alt_indexes["added_indexes"]:
self.add_operation(
app_label,
@@ -1311,6 +1312,7 @@ class MigrationAutodetector:
model_name=model_name,
index=index,
),
dependencies=dependencies,
)
def generate_removed_indexes(self):
@@ -1367,6 +1369,7 @@ class MigrationAutodetector:
app_label,
model_name,
), alt_constraints in self.altered_constraints.items():
dependencies = self._get_dependencies_for_model(app_label, model_name)
for constraint in alt_constraints["added_constraints"]:
self.add_operation(
app_label,
@@ -1374,6 +1377,7 @@ class MigrationAutodetector:
model_name=model_name,
constraint=constraint,
),
dependencies=dependencies,
)
def generate_removed_constraints(self):
@@ -1425,6 +1429,22 @@ class MigrationAutodetector:
dependencies.append((through_app_label, through_object_name, None, True))
return dependencies
def _get_dependencies_for_model(self, app_label, model_name):
"""Return foreign key dependencies of the given model."""
dependencies = []
model_state = self.to_state.models[app_label, model_name]
for field in model_state.fields.values():
if field.is_relation:
dependencies.extend(
self._get_dependencies_for_foreign_key(
app_label,
model_name,
field,
self.to_state,
)
)
return dependencies
def _get_altered_foo_together_operations(self, option_name):
for app_label, model_name in sorted(self.kept_model_keys):
old_model_name = self.renamed_models.get(