From 47fd467bba71cdac0d7000f4be1c63333fcb5b67 Mon Sep 17 00:00:00 2001
From: Jake Howard <git@theorangeone.net>
Date: Thu, 21 Nov 2024 21:12:15 +0000
Subject: [PATCH] Make task ids opaque string

They no longer have to be UUIDs
---
 django/tasks/backends/dummy.py     |  5 ++---
 django/tasks/backends/immediate.py |  5 ++---
 django/tasks/utils.py              | 14 ++++++++++++++
 docs/ref/tasks.txt                 |  4 +++-
 4 files changed, 21 insertions(+), 7 deletions(-)

diff --git a/django/tasks/backends/dummy.py b/django/tasks/backends/dummy.py
index efb15a2888..a44ab8f362 100644
--- a/django/tasks/backends/dummy.py
+++ b/django/tasks/backends/dummy.py
@@ -1,12 +1,11 @@
 from copy import deepcopy
 from functools import partial
-from uuid import uuid4
 
 from django.db import transaction
 from django.tasks.exceptions import ResultDoesNotExist
 from django.tasks.signals import task_enqueued
 from django.tasks.task import ResultStatus, TaskResult
-from django.tasks.utils import json_normalize
+from django.tasks.utils import get_random_id, json_normalize
 from django.utils import timezone
 
 from .base import BaseTaskBackend
@@ -31,7 +30,7 @@ class DummyBackend(BaseTaskBackend):
 
         result = TaskResult(
             task=task,
-            id=str(uuid4()),
+            id=get_random_id(),
             status=ResultStatus.NEW,
             enqueued_at=None,
             started_at=None,
diff --git a/django/tasks/backends/immediate.py b/django/tasks/backends/immediate.py
index 00f842c9c9..eed0e34ed5 100644
--- a/django/tasks/backends/immediate.py
+++ b/django/tasks/backends/immediate.py
@@ -1,14 +1,13 @@
 import logging
 from functools import partial
 from inspect import iscoroutinefunction
-from uuid import uuid4
 
 from asgiref.sync import async_to_sync
 
 from django.db import transaction
 from django.tasks.signals import task_enqueued, task_finished
 from django.tasks.task import ResultStatus, TaskResult
-from django.tasks.utils import exception_to_dict, json_normalize
+from django.tasks.utils import exception_to_dict, get_random_id, json_normalize
 from django.utils import timezone
 
 from .base import BaseTaskBackend
@@ -66,7 +65,7 @@ class ImmediateBackend(BaseTaskBackend):
 
         task_result = TaskResult(
             task=task,
-            id=str(uuid4()),
+            id=get_random_id(),
             status=ResultStatus.NEW,
             enqueued_at=None,
             started_at=None,
diff --git a/django/tasks/utils.py b/django/tasks/utils.py
index a0cfa9c343..a92eae36e6 100644
--- a/django/tasks/utils.py
+++ b/django/tasks/utils.py
@@ -1,9 +1,11 @@
 import inspect
 import json
+import random
 import time
 from functools import wraps
 from traceback import format_exception
 
+from django.utils.crypto import RANDOM_STRING_CHARS
 from django.utils.module_loading import import_string
 
 
@@ -69,3 +71,15 @@ def exception_from_dict(exc_data):
         raise TypeError(f"{type(exc_class)} is not an exception")
 
     return exc_class(*exc_data["exc_args"])
+
+
+def get_random_id():
+    """
+    Return a random string for use as a task id.
+
+    Whilst 64 characters is the max, just use 32 as a sensible middle-ground.
+
+    This should be much faster than `get_random_string`, since
+    it's not cryptographically secure.
+    """
+    return "".join(random.choices(RANDOM_STRING_CHARS, k=32))
diff --git a/docs/ref/tasks.txt b/docs/ref/tasks.txt
index 55af7c61ba..27758690bc 100644
--- a/docs/ref/tasks.txt
+++ b/docs/ref/tasks.txt
@@ -156,7 +156,9 @@ Attributes of ``TaskResult`` cannot be modified.
     A unique identifier for the result, which can be passed to
     :meth:`Task.get_result`.
 
-    The id must be a UUID4, represented as a dashed string.
+    The format of a task result id will depend on the backend being used.
+    Some may use numbers, others UUIDs.
+    Task ids are always strings less than 64 characters.
 
 .. attribute:: TaskResult.status