mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-22 17:16:24 +00:00
Code Issues 25 Releases Wiki Activity

Refs #35326 -- Adjusted deprecation warning stacklevel in FileSystemStorage.OS_OPEN_FLAGS.

Browse Source
This commit is contained in:
Simon Charette 2024-08-09 12:45:44 -04:00 committed by nessita
parent 52ed2b645e
commit 47f18a7226
3 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
django/core/files/storage/filesystem.py
View File

@ -48,6 +48,7 @@ class FileSystemStorage(Storage, StorageSettingsMixin):
"Overriding OS_OPEN_FLAGS is deprecated. Use " "Overriding OS_OPEN_FLAGS is deprecated. Use "
"the allow_overwrite parameter instead.", "the allow_overwrite parameter instead.",
RemovedInDjango60Warning, RemovedInDjango60Warning,
stacklevel=2,
) )
@cached_property @cached_property

4
docs/releases/5.1.1.txt
View File

@ -23,3 +23,7 @@ Bugfixes
* Adjusted the deprecation warning ``stacklevel`` in :meth:`.Model.save` and * Adjusted the deprecation warning ``stacklevel`` in :meth:`.Model.save` and
:meth:`.Model.asave` to correctly point to the offending call site :meth:`.Model.asave` to correctly point to the offending call site
(:ticket:`35060`). (:ticket:`35060`).
* Adjusted the deprecation warning ``stacklevel`` when using ``OS_OPEN_FLAGS``
in :class:`~django.core.files.storage.FileSystemStorage` to correctly point
to the offending call site (:ticket:`35326`).

3
tests/file_storage/tests.py
View File

@ -635,10 +635,11 @@ class OverwritingStorageOSOpenFlagsWarningTests(SimpleTestCase):
def test_os_open_flags_deprecation_warning(self): def test_os_open_flags_deprecation_warning(self):
msg = "Overriding OS_OPEN_FLAGS is deprecated. Use the allow_overwrite " msg = "Overriding OS_OPEN_FLAGS is deprecated. Use the allow_overwrite "
msg += "parameter instead." msg += "parameter instead."
with self.assertWarnsMessage(RemovedInDjango60Warning, msg): with self.assertWarnsMessage(RemovedInDjango60Warning, msg) as ctx:
self.storage = self.storage_class( self.storage = self.storage_class(
location=self.temp_dir, base_url="/test_media_url/" location=self.temp_dir, base_url="/test_media_url/"
) )
self.assertEqual(ctx.filename, __file__)
# RemovedInDjango60Warning: Remove this test class. # RemovedInDjango60Warning: Remove this test class.