1
0
mirror of https://github.com/django/django.git synced 2025-10-24 06:06:09 +00:00

Fixed #25693 -- Prevented data loss with Prefetch and ManyToManyField.

Thanks to Jamie Matthews for finding and explaining the bug.
This commit is contained in:
Ian Foote
2015-11-06 20:18:00 +01:00
committed by Tim Graham
parent dbbae2cead
commit 4608573788
5 changed files with 39 additions and 0 deletions

View File

@@ -223,6 +223,17 @@ class PrefetchRelatedTests(TestCase):
self.assertIn('prefetch_related', str(cm.exception))
self.assertIn("name", str(cm.exception))
def test_m2m_shadow(self):
msg = 'to_attr=books conflicts with a field on the Author model.'
poems = Book.objects.filter(title='Poems')
with self.assertRaisesMessage(ValueError, msg):
list(Author.objects.prefetch_related(
Prefetch('books', queryset=poems, to_attr='books'),
))
# Without the ValueError, a book was deleted due to the implicit
# save of reverse relation assignment.
self.assertEqual(self.author1.books.count(), 2)
class CustomPrefetchTests(TestCase):
@classmethod