From 404870ee1f0d15f6b81d0e0b059068b1f020b2f1 Mon Sep 17 00:00:00 2001 From: Aymeric Augustin Date: Tue, 9 Jul 2013 21:35:01 +0200 Subject: [PATCH] Fixed #20724 -- Test failure on SQLite. This test failure happened if the connection's NAME was set to a file system path, and its TEST_NAME wasn't. Thanks Claude for the report. --- tests/requests/tests.py | 2 +- tests/transactions_regress/tests.py | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/requests/tests.py b/tests/requests/tests.py index b00eec87a9..bf97f7dfe2 100644 --- a/tests/requests/tests.py +++ b/tests/requests/tests.py @@ -679,7 +679,7 @@ class RequestsTests(SimpleTestCase): @skipIf(connection.vendor == 'sqlite' - and connection.settings_dict['NAME'] in ('', ':memory:'), + and connection.settings_dict['TEST_NAME'] in (None, '', ':memory:'), "Cannot establish two connections to an in-memory SQLite database.") class DatabaseConnectionHandlingTests(TransactionTestCase): diff --git a/tests/transactions_regress/tests.py b/tests/transactions_regress/tests.py index bd9e78b033..01f8fc4186 100644 --- a/tests/transactions_regress/tests.py +++ b/tests/transactions_regress/tests.py @@ -191,10 +191,9 @@ class TestTransactionClosing(IgnoreDeprecationWarningsMixin, TransactionTestCase """ self.test_failing_query_transaction_closed() -@skipIf(connection.vendor == 'sqlite' and - (connection.settings_dict['NAME'] == ':memory:' or - not connection.settings_dict['NAME']), - 'Test uses multiple connections, but in-memory sqlite does not support this') +@skipIf(connection.vendor == 'sqlite' + and connection.settings_dict['TEST_NAME'] in (None, '', ':memory:'), + "Cannot establish two connections to an in-memory SQLite database.") class TestNewConnection(IgnoreDeprecationWarningsMixin, TransactionTestCase): """ Check that new connections don't have special behaviour.