mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-22 09:05:43 +00:00
Code Issues 25 Releases Wiki Activity

Refs #26007 -- Improved the ImproperlyConfigured error message for SingleObjectTemplateResponseMixin.get_template_names().

Browse Source
This commit is contained in:
Andrew Miller 2024-12-15 21:04:29 +00:00 committed by Sarah Boyce
parent 0fc6d5362b
commit 3ee4c6a27a
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
django/views/generic/detail.py
View File

@ -171,7 +171,11 @@ class SingleObjectTemplateResponseMixin(TemplateResponseMixin):
# If we still haven't managed to find any template names, we should # If we still haven't managed to find any template names, we should
# re-raise the ImproperlyConfigured to alert the user. # re-raise the ImproperlyConfigured to alert the user.
if not names: if not names:
raise raise ImproperlyConfigured(
"SingleObjectTemplateResponseMixin requires a definition "
"of 'template_name', 'template_name_field', or 'model'; "
"or an implementation of 'get_template_names()'."
)
return names return names

5
tests/generic_views/test_base.py
View File

@ -607,8 +607,9 @@ class SingleObjectTemplateResponseMixinTest(SimpleTestCase):
""" """
view = views.TemplateResponseWithoutTemplate() view = views.TemplateResponseWithoutTemplate()
msg = ( msg = (
"TemplateResponseMixin requires either a definition of " "SingleObjectTemplateResponseMixin requires a definition "
"'template_name' or an implementation of 'get_template_names()'" "of 'template_name', 'template_name_field', or 'model'; "
"or an implementation of 'get_template_names()'."
) )
with self.assertRaisesMessage(ImproperlyConfigured, msg): with self.assertRaisesMessage(ImproperlyConfigured, msg):
view.get_template_names() view.get_template_names()