mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-01-08 17:37:20 +00:00
Code Issues 32 Releases Wiki Activity

Improved ImproperlyConfigured error message in ModelFormMixin.

Browse Source 
Clarified that either 'fields' or 'form_class' attribute must be set
when using ModelFormMixin.
This commit is contained in:
Clifford Gama 2024-10-29 09:40:33 +02:00
parent 43287cbb87
commit 3e4527cc87
No known key found for this signature in database
GPG Key ID: BF895AA45E520E21
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
django/views/generic/edit.py
View File

@ -101,8 +101,9 @@ class ModelFormMixin(FormMixin, SingleObjectMixin):
if self.fields is None: if self.fields is None:
raise ImproperlyConfigured( raise ImproperlyConfigured(
"Using ModelFormMixin (base class of %s) without " "Using ModelFormMixin (base class of %s) without the 'fields' or "
"the 'fields' attribute is prohibited." % self.__class__.__name__ "the 'form_class' attribute is prohibited."
% self.__class__.__name__
) )
return model_forms.modelform_factory(model, fields=self.fields) return model_forms.modelform_factory(model, fields=self.fields)

2
tests/generic_views/test_edit.py
View File

@ -218,7 +218,7 @@ class CreateViewTests(TestCase):
message = ( message = (
"Using ModelFormMixin (base class of MyCreateView) without the " "Using ModelFormMixin (base class of MyCreateView) without the "
"'fields' attribute is prohibited." "'fields' or the 'form_class' attribute is prohibited."
) )
with self.assertRaisesMessage(ImproperlyConfigured, message): with self.assertRaisesMessage(ImproperlyConfigured, message):
MyCreateView().get_form_class() MyCreateView().get_form_class()