mirror of
https://github.com/django/django.git
synced 2024-12-23 01:25:58 +00:00
Simplified how createsuperuser tests generate passwords.
This commit is contained in:
parent
8c70ba92dd
commit
3daac76cfb
@ -524,14 +524,10 @@ class CreatesuperuserManagementCommandTestCase(TestCase):
|
|||||||
Creation should fail if the password fails validation.
|
Creation should fail if the password fails validation.
|
||||||
"""
|
"""
|
||||||
new_io = StringIO()
|
new_io = StringIO()
|
||||||
|
entered_passwords = ['1234567890', '1234567890', 'password', 'password']
|
||||||
|
|
||||||
# Returns '1234567890' the first two times it is called, then
|
def bad_then_good_password():
|
||||||
# 'password' subsequently.
|
return entered_passwords.pop(0)
|
||||||
def bad_then_good_password(index=[0]):
|
|
||||||
index[0] += 1
|
|
||||||
if index[0] <= 2:
|
|
||||||
return '1234567890'
|
|
||||||
return 'password'
|
|
||||||
|
|
||||||
@mock_inputs({
|
@mock_inputs({
|
||||||
'password': bad_then_good_password,
|
'password': bad_then_good_password,
|
||||||
@ -561,13 +557,10 @@ class CreatesuperuserManagementCommandTestCase(TestCase):
|
|||||||
def test_validate_password_against_username(self):
|
def test_validate_password_against_username(self):
|
||||||
new_io = StringIO()
|
new_io = StringIO()
|
||||||
username = 'supremelycomplex'
|
username = 'supremelycomplex'
|
||||||
|
entered_passwords = [username, username, 'superduperunguessablepassword', 'superduperunguessablepassword']
|
||||||
|
|
||||||
def bad_then_good_password(index=[0]):
|
def bad_then_good_password():
|
||||||
"""Return username the first two times, then a valid password."""
|
return entered_passwords.pop(0)
|
||||||
index[0] += 1
|
|
||||||
if index[0] <= 2:
|
|
||||||
return username
|
|
||||||
return 'superduperunguessablepassword'
|
|
||||||
|
|
||||||
@mock_inputs({
|
@mock_inputs({
|
||||||
'password': bad_then_good_password,
|
'password': bad_then_good_password,
|
||||||
@ -599,21 +592,16 @@ class CreatesuperuserManagementCommandTestCase(TestCase):
|
|||||||
)
|
)
|
||||||
def test_validate_password_against_required_fields(self):
|
def test_validate_password_against_required_fields(self):
|
||||||
new_io = StringIO()
|
new_io = StringIO()
|
||||||
username = 'josephine'
|
first_name = 'josephine'
|
||||||
|
entered_passwords = [first_name, first_name, 'superduperunguessablepassword', 'superduperunguessablepassword']
|
||||||
|
|
||||||
# Returns the username the first two times it's called, then a valid
|
def bad_then_good_password():
|
||||||
# password.
|
return entered_passwords.pop(0)
|
||||||
def bad_then_good_password(index=[0]):
|
|
||||||
"""Return username the first two times, then a valid password."""
|
|
||||||
index[0] += 1
|
|
||||||
if index[0] <= 2:
|
|
||||||
return username
|
|
||||||
return 'superduperunguessablepassword'
|
|
||||||
|
|
||||||
@mock_inputs({
|
@mock_inputs({
|
||||||
'password': bad_then_good_password,
|
'password': bad_then_good_password,
|
||||||
'username': username,
|
'username': 'whatever',
|
||||||
'first_name': 'josephine',
|
'first_name': first_name,
|
||||||
'date_of_birth': '1970-01-01',
|
'date_of_birth': '1970-01-01',
|
||||||
'email': 'joey@example.com',
|
'email': 'joey@example.com',
|
||||||
'bypass': 'n',
|
'bypass': 'n',
|
||||||
|
Loading…
Reference in New Issue
Block a user