mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 09:41:08 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #31395 -- Made setUpTestData enforce in-memory data isolation.

Browse Source 
Since it's introduction in Django 1.8 setUpTestData has been suffering
from a documented but confusing caveat due to its sharing of attributes
assigned during its execution with all test instances.

By keeping track of class attributes assigned during the setUpTestData
phase its possible to ensure only deep copies are provided to test
instances on attribute retreival and prevent manual setUp gymnastic to
work around the previous lack of in-memory data isolation.

Thanks Adam Johnson for the extensive review.
This commit is contained in:
Simon Charette
2018-11-23 21:22:09 -05:00
committed by Mariusz Felisiak
parent 1dd96f731d
commit 3cf80d3fcf
6 changed files with 178 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
docs/releases/3.2.txt
View File

@@ -195,7 +195,10 @@ Templates
Tests
~~~~~
* ...
* Objects assigned to class attributes in :meth:`.TestCase.setUpTestData` are
now isolated for each test method. Such objects are now required to support
creating deep copies with :py:func:`copy.deepcopy`. Assigning objects which
don't support ``deepcopy()`` is deprecated and will be removed in Django 4.1.
URLs
~~~~
@@ -255,4 +258,6 @@ Features deprecated in 3.2
Miscellaneous
-------------
* ...
* Assigning objects which don't support creating deep copies with
:py:func:`copy.deepcopy` to class attributes in
:meth:`.TestCase.setUpTestData` is deprecated.