mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 09:41:08 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #28645 -- Reallowed AuthenticationForm to raise the inactive user error when using ModelBackend.

Browse Source 
Regression in e0a3d93730.

Thanks Guilherme Junqueira for the report and Tim Graham for the review.
This commit is contained in:
shanghui
2017-11-08 16:32:49 +08:00
committed by Tim Graham
parent 3ae9c356c5
commit 359370a8b8
3 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/auth_tests/test_forms.py
View File

@@ -262,9 +262,6 @@ class UserCreationFormTest(TestDataMixin, TestCase):
)
# To verify that the login form rejects inactive users, use an authentication
# backend that allows them.
@override_settings(AUTHENTICATION_BACKENDS=['django.contrib.auth.backends.AllowAllUsersModelBackend'])
class AuthenticationFormTest(TestDataMixin, TestCase):
def test_invalid_username(self):
@@ -323,6 +320,8 @@ class AuthenticationFormTest(TestDataMixin, TestCase):
self.assertFalse(form.is_valid())
self.assertEqual(form.non_field_errors(), [str(form.error_messages['inactive'])])
# Use an authentication backend that allows inactive users.
@override_settings(AUTHENTICATION_BACKENDS=['django.contrib.auth.backends.AllowAllUsersModelBackend'])
def test_custom_login_allowed_policy(self):
# The user is inactive, but our custom form policy allows them to log in.
data = {