mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-01-18 14:24:39 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #34071 -- Improved error message for Range(Min/Max)ValueValidator.

Browse Source
This commit is contained in:
Jack Linke 2022-10-03 01:57:24 -04:00 committed by Mariusz Felisiak
parent a142edcc49
commit 344d31c7e9
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
django/contrib/postgres/validators.py
View File

@ -78,7 +78,7 @@ class RangeMaxValueValidator(MaxValueValidator):
return a.upper is None or a.upper > b return a.upper is None or a.upper > b
message = _( message = _(
"Ensure that this range is completely less than or equal to %(limit_value)s." "Ensure that the upper bound of the range is not greater than %(limit_value)s."
) )
@ -87,5 +87,5 @@ class RangeMinValueValidator(MinValueValidator):
return a.lower is None or a.lower < b return a.lower is None or a.lower < b
message = _( message = _(
"Ensure that this range is completely greater than or equal to %(limit_value)s." "Ensure that the lower bound of the range is not less than %(limit_value)s."
) )

4
tests/postgres_tests/test_ranges.py
View File

@ -631,7 +631,7 @@ class TestValidators(PostgreSQLSimpleTestCase):
def test_max(self): def test_max(self):
validator = RangeMaxValueValidator(5) validator = RangeMaxValueValidator(5)
validator(NumericRange(0, 5)) validator(NumericRange(0, 5))
msg = "Ensure that this range is completely less than or equal to 5." msg = "Ensure that the upper bound of the range is not greater than 5."
with self.assertRaises(exceptions.ValidationError) as cm: with self.assertRaises(exceptions.ValidationError) as cm:
validator(NumericRange(0, 10)) validator(NumericRange(0, 10))
self.assertEqual(cm.exception.messages[0], msg) self.assertEqual(cm.exception.messages[0], msg)
@ -642,7 +642,7 @@ class TestValidators(PostgreSQLSimpleTestCase):
def test_min(self): def test_min(self):
validator = RangeMinValueValidator(5) validator = RangeMinValueValidator(5)
validator(NumericRange(10, 15)) validator(NumericRange(10, 15))
msg = "Ensure that this range is completely greater than or equal to 5." msg = "Ensure that the lower bound of the range is not less than 5."
with self.assertRaises(exceptions.ValidationError) as cm: with self.assertRaises(exceptions.ValidationError) as cm:
validator(NumericRange(0, 10)) validator(NumericRange(0, 10))
self.assertEqual(cm.exception.messages[0], msg) self.assertEqual(cm.exception.messages[0], msg)