1
0
mirror of https://github.com/django/django.git synced 2025-10-29 08:36:09 +00:00

To avoid an unfortunately common user-error, rename QuerySet.as_sql().

This was never a public API method, so this is backwards compatible, unless
you're poking at the internals. Refs #10352.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@9928 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
Malcolm Tredinnick
2009-03-01 04:12:30 +00:00
parent c6a404d1e9
commit 3242df16e4
3 changed files with 12 additions and 9 deletions

View File

@@ -703,12 +703,9 @@ class QuerySet(object):
self.query.add_fields(field_names, False)
self.query.set_group_by()
def as_sql(self):
def _as_sql(self):
"""
Returns the internal query's SQL and parameters (as a tuple).
This is a private (internal) method. The name is chosen to provide
uniformity with other interfaces (in particular, the Query class).
"""
obj = self.values("pk")
return obj.query.as_nested_sql()
@@ -812,7 +809,7 @@ class ValuesQuerySet(QuerySet):
super(ValuesQuerySet, self)._setup_aggregate_query(aggregates)
def as_sql(self):
def _as_sql(self):
"""
For ValueQuerySet (and subclasses like ValuesListQuerySet), they can
only be used as nested queries if they're already set up to select only