mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 01:25:32 +00:00
Code Issues 32 Releases Wiki Activity

Refs #29984 -- Made QuerySet.iterator() without chunk_size raise ValueError after prefetch_related().

Browse Source 
Per deprecation timeline.
This commit is contained in:
Mariusz Felisiak
2023-01-12 19:13:22 +01:00
parent 5a0e5d5cf0
commit 2e4d188e7c
4 changed files with 11 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/prefetch_related/tests.py
View File

@@ -12,8 +12,7 @@ from django.test import (
skipIfDBFeature,
skipUnlessDBFeature,
)
from django.test.utils import CaptureQueriesContext, ignore_warnings
from django.utils.deprecation import RemovedInDjango50Warning
from django.test.utils import CaptureQueriesContext
from .models import (
Article,
@@ -385,25 +384,12 @@ class PrefetchRelatedTests(TestDataMixin, TestCase):
[self.author1, self.author1, self.author3, self.author4],
)
@ignore_warnings(category=RemovedInDjango50Warning)
def test_m2m_prefetching_iterator_without_chunks(self):
# prefetch_related() is ignored.
with self.assertNumQueries(5):
authors = [
b.authors.first()
for b in Book.objects.prefetch_related("authors").iterator()
]
self.assertEqual(
authors,
[self.author1, self.author1, self.author3, self.author4],
)
def test_m2m_prefetching_iterator_without_chunks_warning(self):
def test_m2m_prefetching_iterator_without_chunks_error(self):
msg = (
"Using QuerySet.iterator() after prefetch_related() without "
"specifying chunk_size is deprecated."
"chunk_size must be provided when using QuerySet.iterator() after "
"prefetch_related()."
)
with self.assertWarnsMessage(RemovedInDjango50Warning, msg):
with self.assertRaisesMessage(ValueError, msg):
Book.objects.prefetch_related("authors").iterator()