mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-05-22 06:46:27 +00:00
Code Issues 32 Releases Wiki Activity

Refs #34338 -- Fixed isolation of constraints tests.

Browse Source 
Regression in 5b3d3e400ab9334ba429ca360c9818c6dfc3a51b.
This commit is contained in:
Mariusz Felisiak 2023-02-24 09:02:45 +01:00 committed by GitHub
parent 40e88ae8c8
commit 2c428b37ae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/constraints/models.py
View File

@ -34,7 +34,13 @@ class UniqueConstraintProduct(models.Model):
class Meta: class Meta:
constraints = [ constraints = [
models.UniqueConstraint(fields=["name", "color"], name="name_color_uniq"), models.UniqueConstraint(
fields=["name", "color"],
name="name_color_uniq",
# Custom message and error code are ignored.
violation_error_code="custom_code",
violation_error_message="Custom message",
)
] ]

13
tests/constraints/tests.py
View File

@ -744,9 +744,6 @@ class UniqueConstraintTests(TestCase):
def test_validate(self): def test_validate(self):
constraint = UniqueConstraintProduct._meta.constraints[0] constraint = UniqueConstraintProduct._meta.constraints[0]
# Custom message and error code are ignored.
constraint.violation_error_message = "Custom message"
constraint.violation_error_code = "custom_code"
msg = "Unique constraint product with this Name and Color already exists." msg = "Unique constraint product with this Name and Color already exists."
non_unique_product = UniqueConstraintProduct( non_unique_product = UniqueConstraintProduct(
name=self.p1.name, color=self.p1.color name=self.p1.name, color=self.p1.color
@ -811,9 +808,13 @@ class UniqueConstraintTests(TestCase):
@skipUnlessDBFeature("supports_partial_indexes") @skipUnlessDBFeature("supports_partial_indexes")
def test_validate_conditon_custom_error(self): def test_validate_conditon_custom_error(self):
p1 = UniqueConstraintConditionProduct.objects.create(name="p1") p1 = UniqueConstraintConditionProduct.objects.create(name="p1")
constraint = UniqueConstraintConditionProduct._meta.constraints[0] constraint = models.UniqueConstraint(
constraint.violation_error_message = "Custom message" fields=["name"],
constraint.violation_error_code = "custom_code" name="name_without_color_uniq",
condition=models.Q(color__isnull=True),
violation_error_code="custom_code",
violation_error_message="Custom message",
)
msg = "Custom message" msg = "Custom message"
with self.assertRaisesMessage(ValidationError, msg) as cm: with self.assertRaisesMessage(ValidationError, msg) as cm:
constraint.validate( constraint.validate(