mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-22 17:16:24 +00:00
Code Issues 25 Releases Wiki Activity

Removed redundant RemoteTestResultTest._test_error_exc_info() test hook.

Browse Source
This commit is contained in:
Mariusz Felisiak 2024-11-08 22:06:29 +01:00 committed by Sarah Boyce
parent 398cec434b
commit 2bc43ccbdb
1 changed files with 11 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
tests/test_runner/test_parallel.py
View File

@ -15,6 +15,13 @@ except ImportError:
tblib = None tblib = None
def _test_error_exc_info():
try:
raise ValueError("woops")
except ValueError:
return sys.exc_info()
class ExceptionThatFailsUnpickling(Exception): class ExceptionThatFailsUnpickling(Exception):
""" """
After pickling, this class fails unpickling with an error about incorrect After pickling, this class fails unpickling with an error about incorrect
@ -75,12 +82,6 @@ class SampleErrorTest(SimpleTestCase):
class RemoteTestResultTest(SimpleTestCase): class RemoteTestResultTest(SimpleTestCase):
def _test_error_exc_info(self):
try:
raise ValueError("woops")
except ValueError:
return sys.exc_info()
def test_was_successful_no_events(self): def test_was_successful_no_events(self):
result = RemoteTestResult() result = RemoteTestResult()
self.assertIs(result.wasSuccessful(), True) self.assertIs(result.wasSuccessful(), True)
@ -100,7 +101,7 @@ class RemoteTestResultTest(SimpleTestCase):
test = None test = None
result.startTest(test) result.startTest(test)
try: try:
result.addExpectedFailure(test, self._test_error_exc_info()) result.addExpectedFailure(test, _test_error_exc_info())
finally: finally:
result.stopTest(test) result.stopTest(test)
self.assertIs(result.wasSuccessful(), True) self.assertIs(result.wasSuccessful(), True)
@ -121,7 +122,7 @@ class RemoteTestResultTest(SimpleTestCase):
test = None test = None
result.startTest(test) result.startTest(test)
try: try:
result.addError(test, self._test_error_exc_info()) result.addError(test, _test_error_exc_info())
finally: finally:
result.stopTest(test) result.stopTest(test)
self.assertIs(result.wasSuccessful(), False) self.assertIs(result.wasSuccessful(), False)
@ -132,7 +133,7 @@ class RemoteTestResultTest(SimpleTestCase):
test = None test = None
result.startTest(test) result.startTest(test)
try: try:
result.addFailure(test, self._test_error_exc_info()) result.addFailure(test, _test_error_exc_info())
finally: finally:
result.stopTest(test) result.stopTest(test)
self.assertIs(result.wasSuccessful(), False) self.assertIs(result.wasSuccessful(), False)
@ -143,7 +144,7 @@ class RemoteTestResultTest(SimpleTestCase):
test_id = "test_foo (tests.test_foo.FooTest.test_foo)" test_id = "test_foo (tests.test_foo.FooTest.test_foo)"
test = _ErrorHolder(test_id) test = _ErrorHolder(test_id)
# Call addError() without a call to startTest(). # Call addError() without a call to startTest().
result.addError(test, self._test_error_exc_info()) result.addError(test, _test_error_exc_info())
(event,) = result.events (event,) = result.events
self.assertEqual(event[0], "addError") self.assertEqual(event[0], "addError")
@ -283,10 +284,3 @@ class ParallelTestSuiteTest(SimpleTestCase):
self.assertEqual(len(result.errors), 0) self.assertEqual(len(result.errors), 0)
self.assertEqual(len(result.failures), 0) self.assertEqual(len(result.failures), 0)
def _test_error_exc_info():
try:
raise ValueError("woops")
except ValueError:
return sys.exc_info()