mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-24 06:06:09 +00:00
Code Issues 32 Releases Wiki Activity

Refs #19544 -- Ignored auto-created through additions conflicts if supported.

Browse Source 
This prevents IntegrityError caused by race conditions between missing ids
retrieval and bulk insertions.
This commit is contained in:
Simon Charette
2019-02-15 01:01:25 -05:00
committed by Tim Graham
parent dd32f9a3a2
commit 28712d8acf
2 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/many_to_many/tests.py
View File

@@ -117,6 +117,16 @@ class ManyToManyTests(TestCase):
]
)
@skipUnlessDBFeature('supports_ignore_conflicts')
def test_add_ignore_conflicts(self):
manager_cls = self.a1.publications.__class__
# Simulate a race condition between the missing ids retrieval and
# the bulk insertion attempt.
missing_target_ids = {self.p1.id}
with mock.patch.object(manager_cls, '_get_missing_target_ids', return_value=missing_target_ids) as mocked:
self.a1.publications.add(self.p1)
mocked.assert_called_once()
def test_related_sets(self):
# Article objects have access to their related Publication objects.
self.assertQuerysetEqual(self.a1.publications.all(), ['<Publication: The Python Journal>'])