1
0
mirror of https://github.com/django/django.git synced 2025-11-07 07:15:35 +00:00

Fixed #18394 -- Added error for invalid JavaScriptCatalog packages

Thanks Tim Graham for the review.
This commit is contained in:
Claude Paroz
2017-04-02 20:14:39 +02:00
parent 41e02ab368
commit 23142eea85
3 changed files with 22 additions and 2 deletions

View File

@@ -4,14 +4,15 @@ from os import path
from django.conf import settings
from django.test import (
SimpleTestCase, TestCase, modify_settings, override_settings,
RequestFactory, SimpleTestCase, TestCase, modify_settings,
override_settings,
)
from django.test.selenium import SeleniumTestCase
from django.urls import reverse
from django.utils.translation import (
LANGUAGE_SESSION_KEY, get_language, override,
)
from django.views.i18n import get_formats
from django.views.i18n import JavaScriptCatalog, get_formats
from ..urls import locale_dir
@@ -397,6 +398,16 @@ class I18NViewTests(SimpleTestCase):
response = self.client.get('/jsi18n/')
self.assertContains(response, 'este texto de app3 debe ser traducido')
def test_i18n_unknown_package_error(self):
view = JavaScriptCatalog.as_view()
request = RequestFactory().get('/')
msg = 'Invalid package(s) provided to JavaScriptCatalog: unknown_package'
with self.assertRaisesMessage(ValueError, msg):
view(request, packages='unknown_package')
msg += ',unknown_package2'
with self.assertRaisesMessage(ValueError, msg):
view(request, packages='unknown_package+unknown_package2')
@override_settings(ROOT_URLCONF='view_tests.urls')
class I18nSeleniumTests(SeleniumTestCase):