From 22da62f2391b88b524e33f79956db998b9522fb5 Mon Sep 17 00:00:00 2001 From: Adrian Holovaty Date: Wed, 7 Jun 2006 04:22:42 +0000 Subject: [PATCH] Fixed #1503 -- Improved model validator to throw an error if a model doesn't manually define a primary key and has a field named 'id', which conflicts with the auto-primary-key convention. Thanks, mir@noris.de git-svn-id: http://code.djangoproject.com/svn/django/trunk@3100 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- django/core/management.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/django/core/management.py b/django/core/management.py index a94782b6b1..87db88611a 100644 --- a/django/core/management.py +++ b/django/core/management.py @@ -815,6 +815,8 @@ def get_validation_errors(outfile, app=None): # Do field-specific validation. for f in opts.fields: + if f.name == 'id' and not f.primary_key and opts.pk.name == 'id': + e.add(opts, '"%s": You can\'t use "id" as a field name, because each model automatically gets an "id" field if none of the fields have primary_key=True. You need to either remove/rename your "id" field or add primary_key=True to a field.' % f.name) if isinstance(f, models.CharField) and f.maxlength in (None, 0): e.add(opts, '"%s": CharFields require a "maxlength" attribute.' % f.name) if isinstance(f, models.FloatField):