mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-30 17:16:10 +00:00
Code Issues 32 Releases Wiki Activity

Refs #32817 -- Added tests for bad CSRF token provided via X-CSRFToken or custom header.

Browse Source
This commit is contained in:
Chris Jerdonek
2021-06-08 02:19:24 -07:00
committed by Mariusz Felisiak
parent 6837bd68a4
commit 1a284afb07
1 changed files with 35 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
tests/csrf_tests/tests.py
View File

@@ -125,8 +125,14 @@ class CsrfViewMiddlewareTestMixin:
""" """
self._check_bad_or_missing_cookie(None, REASON_NO_CSRF_COOKIE) self._check_bad_or_missing_cookie(None, REASON_NO_CSRF_COOKIE)
def _check_bad_or_missing_token(self, expected, token=None): def _check_bad_or_missing_token(
req = self._get_POST_csrf_cookie_request(post_token=token) self, expected, post_token=None, meta_token=None, token_header=None,
):
req = self._get_POST_csrf_cookie_request(
post_token=post_token,
meta_token=meta_token,
token_header=token_header,
)
mw = CsrfViewMiddleware(post_form_view) mw = CsrfViewMiddleware(post_form_view)
mw.process_request(req) mw.process_request(req)
with self.assertLogs('django.security.csrf', 'WARNING') as cm: with self.assertLogs('django.security.csrf', 'WARNING') as cm:
@@ -140,14 +146,34 @@ class CsrfViewMiddlewareTestMixin:
middleware rejects the incoming request. middleware rejects the incoming request.
""" """
cases = [ cases = [
(None, REASON_CSRF_TOKEN_MISSING), (None, None, REASON_CSRF_TOKEN_MISSING),
(64 * '*', 'CSRF token has invalid characters.'), (16 * 'a', None, 'CSRF token has incorrect length.'),
(16 * 'a', 'CSRF token has incorrect length.'), (64 * '*', None, 'CSRF token has invalid characters.'),
(64 * 'a', 'CSRF token incorrect.'), (64 * 'a', None, 'CSRF token incorrect.'),
(None, 16 * 'a', 'CSRF token has incorrect length.'),
(None, 64 * '*', 'CSRF token has invalid characters.'),
(None, 64 * 'a', 'CSRF token incorrect.'),
] ]
for token, expected in cases: for post_token, meta_token, expected in cases:
with self.subTest(token=token): with self.subTest(post_token=post_token, meta_token=meta_token):
self._check_bad_or_missing_token(expected, token) self._check_bad_or_missing_token(
expected,
post_token=post_token,
meta_token=meta_token,
)
@override_settings(CSRF_HEADER_NAME='HTTP_X_CSRFTOKEN_CUSTOMIZED')
def test_csrf_cookie_bad_token_custom_header(self):
"""
If a CSRF cookie is present and an invalid token is passed via a
custom CSRF_HEADER_NAME, the middleware rejects the incoming request.
"""
expected = 'CSRF token has incorrect length.'
self._check_bad_or_missing_token(
expected,
meta_token=16 * 'a',
token_header='HTTP_X_CSRFTOKEN_CUSTOMIZED',
)
def test_process_request_csrf_cookie_and_token(self): def test_process_request_csrf_cookie_and_token(self):
""" """