From 14172cf4426de6c867028f1c194011c0a26e662d Mon Sep 17 00:00:00 2001 From: Tim Graham Date: Thu, 27 Jul 2017 08:42:01 -0400 Subject: [PATCH] Fixed #28415 -- Clarified what characters ASCII/UnicodeUsernameValidator accept. --- docs/ref/contrib/auth.txt | 18 +++++++++--------- docs/releases/1.10.txt | 8 ++++---- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/docs/ref/contrib/auth.txt b/docs/ref/contrib/auth.txt index 31c8641bb2..b4b407272a 100644 --- a/docs/ref/contrib/auth.txt +++ b/docs/ref/contrib/auth.txt @@ -34,12 +34,12 @@ Fields .. admonition:: Usernames and Unicode - Django originally accepted only ASCII letters in usernames. - Although it wasn't a deliberate choice, Unicode characters have - always been accepted when using Python 3. Django 1.10 officially - added Unicode support in usernames, keeping the ASCII-only behavior - on Python 2, with the option to customize the behavior using - :attr:`.User.username_validator`. + Django originally accepted only ASCII letters and numbers in + usernames. Although it wasn't a deliberate choice, Unicode + characters have always been accepted when using Python 3. Django + 1.10 officially added Unicode support in usernames, keeping the + ASCII-only behavior on Python 2, with the option to customize the + behavior using :attr:`.User.username_validator`. .. attribute:: first_name @@ -395,12 +395,12 @@ Validators .. class:: validators.ASCIIUsernameValidator - A field validator allowing only ASCII letters, in addition to ``@``, ``.``, - ``+``, ``-``, and ``_``. + A field validator allowing only ASCII letters and numbers, in addition to + ``@``, ``.``, ``+``, ``-``, and ``_``. .. class:: validators.UnicodeUsernameValidator - A field validator allowing Unicode letters, in addition to ``@``, ``.``, + A field validator allowing Unicode characters, in addition to ``@``, ``.``, ``+``, ``-``, and ``_``. The default validator for ``User.username``. .. _topics-auth-signals: diff --git a/docs/releases/1.10.txt b/docs/releases/1.10.txt index 444a827898..5be4065d59 100644 --- a/docs/releases/1.10.txt +++ b/docs/releases/1.10.txt @@ -55,11 +55,11 @@ Official support for Unicode usernames -------------------------------------- The :class:`~django.contrib.auth.models.User` model in ``django.contrib.auth`` -originally only accepted ASCII letters in usernames. Although it wasn't a -deliberate choice, Unicode characters have always been accepted when using -Python 3. +originally only accepted ASCII letters and numbers in usernames. Although it +wasn't a deliberate choice, Unicode characters have always been accepted when +using Python 3. -The username validator now explicitly accepts Unicode letters by +The username validator now explicitly accepts Unicode characters by default on Python 3 only. This default behavior can be overridden by changing the :attr:`~django.contrib.auth.models.User.username_validator` attribute of the ``User`` model, or to any proxy of that model, using either