mirror of
https://github.com/django/django.git
synced 2025-10-28 16:16:12 +00:00
[1.10.x] Fixed #26747 -- Used more specific assertions in the Django test suite.
Backport of 4f336f6652 from master
This commit is contained in:
@@ -223,8 +223,8 @@ class MethodDecoratorTests(SimpleTestCase):
|
||||
def func():
|
||||
pass
|
||||
|
||||
self.assertEqual(getattr(func, 'myattr', False), True)
|
||||
self.assertEqual(getattr(func, 'myattr2', False), True)
|
||||
self.assertIs(getattr(func, 'myattr', False), True)
|
||||
self.assertIs(getattr(func, 'myattr2', False), True)
|
||||
|
||||
# Decorate using method_decorator() on the method.
|
||||
class TestPlain(object):
|
||||
@@ -254,11 +254,11 @@ class MethodDecoratorTests(SimpleTestCase):
|
||||
pass
|
||||
|
||||
for Test in (TestPlain, TestMethodAndClass, TestIterable):
|
||||
self.assertEqual(getattr(Test().method, 'myattr', False), True)
|
||||
self.assertEqual(getattr(Test().method, 'myattr2', False), True)
|
||||
self.assertIs(getattr(Test().method, 'myattr', False), True)
|
||||
self.assertIs(getattr(Test().method, 'myattr2', False), True)
|
||||
|
||||
self.assertEqual(getattr(Test.method, 'myattr', False), True)
|
||||
self.assertEqual(getattr(Test.method, 'myattr2', False), True)
|
||||
self.assertIs(getattr(Test.method, 'myattr', False), True)
|
||||
self.assertIs(getattr(Test.method, 'myattr2', False), True)
|
||||
|
||||
self.assertEqual(Test.method.__doc__, 'A method')
|
||||
self.assertEqual(Test.method.__name__, 'method')
|
||||
@@ -280,7 +280,7 @@ class MethodDecoratorTests(SimpleTestCase):
|
||||
def method(self):
|
||||
return True
|
||||
|
||||
self.assertEqual(Test().method(), False)
|
||||
self.assertIs(Test().method(), False)
|
||||
|
||||
def test_descriptors(self):
|
||||
|
||||
@@ -438,13 +438,13 @@ class XFrameOptionsDecoratorsTests(TestCase):
|
||||
return HttpResponse()
|
||||
req = HttpRequest()
|
||||
resp = a_view(req)
|
||||
self.assertEqual(resp.get('X-Frame-Options', None), None)
|
||||
self.assertIsNone(resp.get('X-Frame-Options', None))
|
||||
self.assertTrue(resp.xframe_options_exempt)
|
||||
|
||||
# Since the real purpose of the exempt decorator is to suppress
|
||||
# the middleware's functionality, let's make sure it actually works...
|
||||
r = XFrameOptionsMiddleware().process_response(req, resp)
|
||||
self.assertEqual(r.get('X-Frame-Options', None), None)
|
||||
self.assertIsNone(r.get('X-Frame-Options', None))
|
||||
|
||||
|
||||
class NeverCacheDecoratorTest(TestCase):
|
||||
|
||||
Reference in New Issue
Block a user