From 11c1e61b99f40ed3e8d050fc88b624f52092b630 Mon Sep 17 00:00:00 2001 From: Alex Gaynor Date: Mon, 26 Sep 2011 10:11:18 +0000 Subject: [PATCH] Fixed #16925 -- Make sure a signal is disconnected if the test fails. Thanks to aaugustin for the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@16905 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- .../regressiontests/fixtures_regress/tests.py | 28 ++++++++++--------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/tests/regressiontests/fixtures_regress/tests.py b/tests/regressiontests/fixtures_regress/tests.py index 575983ba81..b8e691490a 100644 --- a/tests/regressiontests/fixtures_regress/tests.py +++ b/tests/regressiontests/fixtures_regress/tests.py @@ -277,19 +277,21 @@ class TestFixtures(TestCase): global pre_save_checks pre_save_checks = [] signals.pre_save.connect(animal_pre_save_check) - management.call_command( - 'loaddata', - 'animal.xml', - verbosity=0, - commit=False, - ) - self.assertEqual( - pre_save_checks, - [ - ("Count = 42 ()", "Weight = 1.2 ()") - ] - ) - signals.pre_save.disconnect(animal_pre_save_check) + try: + management.call_command( + 'loaddata', + 'animal.xml', + verbosity=0, + commit=False, + ) + self.assertEqual( + pre_save_checks, + [ + ("Count = 42 ()", "Weight = 1.2 ()") + ] + ) + finally: + signals.pre_save.disconnect(animal_pre_save_check) def test_dumpdata_uses_default_manager(self): """