mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-22 17:16:24 +00:00
Code Issues 25 Releases Wiki Activity

Refs #32285 -- Made AppConfigStub do not call super().__init__().

Browse Source 
Calling super().__init__() is unnecessary and enforces the use of
various workarounds.
This commit is contained in:
Hasan Ramezani 2020-12-22 08:36:56 +01:00 committed by Mariusz Felisiak
parent 2a76f43134
commit 110001d0bb
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
django/db/migrations/state.py
View File

@ -227,15 +227,14 @@ class ProjectState:
class AppConfigStub(AppConfig): class AppConfigStub(AppConfig):
"""Stub of an AppConfig. Only provides a label and a dict of models.""" """Stub of an AppConfig. Only provides a label and a dict of models."""
# Not used, but required by AppConfig.__init__
path = ''
def __init__(self, label): def __init__(self, label):
self.label = label self.apps = None
self.models = {}
# App-label and app-name are not the same thing, so technically passing # App-label and app-name are not the same thing, so technically passing
# in the label here is wrong. In practice, migrations don't care about # in the label here is wrong. In practice, migrations don't care about
# the app name, but we need something unique, and the label works fine. # the app name, but we need something unique, and the label works fine.
super().__init__(label, None) self.label = label
self.name = label
def import_models(self): def import_models(self):
self.models = self.apps.all_models[self.label] self.models = self.apps.all_models[self.label]
@ -332,7 +331,6 @@ class StateApps(Apps):
if app_label not in self.app_configs: if app_label not in self.app_configs:
self.app_configs[app_label] = AppConfigStub(app_label) self.app_configs[app_label] = AppConfigStub(app_label)
self.app_configs[app_label].apps = self self.app_configs[app_label].apps = self
self.app_configs[app_label].models = {}
self.app_configs[app_label].models[model._meta.model_name] = model self.app_configs[app_label].models[model._meta.model_name] = model
self.do_pending_operations(model) self.do_pending_operations(model)
self.clear_cache() self.clear_cache()