mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-24 06:06:09 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #16935 - misleading message if AttributeError escapes during SimpleTemplateResponse.render

Browse Source 
Thanks to isagalaev for the report.

As discussed on django-devs, this reverts some of the changes in [16568]
i.e.  the addition of `SimpleTemplateResponse.__getattr__`, because this
makes it much harder to debug the common case of an AttributeError somewhere
during the rendering of a SimpleTemplateResponse.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@16917 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
Luke Plant
2011-09-30 11:46:23 +00:00
parent 5009e45dfe
commit 10d90cba83
2 changed files with 3 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/regressiontests/templates/response.py
View File

@@ -9,8 +9,7 @@ from django.conf import settings
import django.template.context
from django.template import Template, Context
from django.template.response import (TemplateResponse, SimpleTemplateResponse,
ContentNotRenderedError,
DiscardedAttributeError)
ContentNotRenderedError)
def test_processor(request):
return {'processors': 'yes'}
@@ -198,7 +197,7 @@ class SimpleTemplateResponseTest(BaseTemplateResponseTest):
# ...and requesting any of those attributes raises an exception
for attr in template_attrs:
with self.assertRaises(DiscardedAttributeError) as cm:
with self.assertRaises(AttributeError):
getattr(unpickled_response, attr)
def test_repickling(self):
@@ -282,7 +281,7 @@ class TemplateResponseTest(BaseTemplateResponseTest):
# ...and requesting any of those attributes raises an exception
for attr in template_attrs:
with self.assertRaises(DiscardedAttributeError) as cm:
with self.assertRaises(AttributeError):
getattr(unpickled_response, attr)
def test_repickling(self):