1
0
mirror of https://github.com/django/django.git synced 2025-10-31 09:41:08 +00:00

[4.2.x] Fixed #34932 -- Restored varchar_pattern_ops/text_pattern_ops index creation when deterministic collaction is set.

Regression in f3f9d03edf (4.2) and
8ed25d65ea (5.0).

Backport of 34b411762b from main.
This commit is contained in:
Tom Carrick
2023-10-27 15:46:05 +02:00
committed by Mariusz Felisiak
parent 61612990d8
commit 109f39a38b
4 changed files with 121 additions and 1 deletions

View File

@@ -227,6 +227,18 @@ class SchemaTests(TransactionTestCase):
constraints_for_column.append(name)
return sorted(constraints_for_column)
def get_constraint_opclasses(self, constraint_name):
with connection.cursor() as cursor:
sql = """
SELECT opcname
FROM pg_opclass AS oc
JOIN pg_index as i on oc.oid = ANY(i.indclass)
JOIN pg_class as c on c.oid = i.indexrelid
WHERE c.relname = %s
"""
cursor.execute(sql, [constraint_name])
return [row[0] for row in cursor.fetchall()]
def check_added_field_default(
self,
schema_editor,
@@ -1378,6 +1390,95 @@ class SchemaTests(TransactionTestCase):
)
self.assertIn("field", self.get_uniques(CiCharModel._meta.db_table))
@isolate_apps("schema")
@unittest.skipUnless(connection.vendor == "postgresql", "PostgreSQL specific")
@skipUnlessDBFeature("supports_collation_on_charfield")
def test_unique_with_deterministic_collation_charfield(self):
deterministic_collation = connection.features.test_collations.get(
"deterministic"
)
if not deterministic_collation:
self.skipTest("This backend does not support deterministic collations.")
class CharModel(Model):
field = CharField(db_collation=deterministic_collation, unique=True)
class Meta:
app_label = "schema"
# Create the table.
with connection.schema_editor() as editor:
editor.create_model(CharModel)
self.isolated_local_models = [CharModel]
constraints = self.get_constraints_for_column(
CharModel, CharModel._meta.get_field("field").column
)
self.assertIn("schema_charmodel_field_8b338dea_like", constraints)
self.assertIn(
"varchar_pattern_ops",
self.get_constraint_opclasses("schema_charmodel_field_8b338dea_like"),
)
self.assertEqual(
self.get_column_collation(CharModel._meta.db_table, "field"),
deterministic_collation,
)
self.assertIn("field", self.get_uniques(CharModel._meta.db_table))
@isolate_apps("schema")
@unittest.skipUnless(connection.vendor == "postgresql", "PostgreSQL specific")
@skipUnlessDBFeature("supports_collation_on_charfield")
def test_relation_to_deterministic_collation_charfield(self):
deterministic_collation = connection.features.test_collations.get(
"deterministic"
)
if not deterministic_collation:
self.skipTest("This backend does not support deterministic collations.")
class CharModel(Model):
field = CharField(db_collation=deterministic_collation, unique=True)
class Meta:
app_label = "schema"
class RelationModel(Model):
field = OneToOneField(CharModel, CASCADE, to_field="field")
class Meta:
app_label = "schema"
# Create the table.
with connection.schema_editor() as editor:
editor.create_model(CharModel)
editor.create_model(RelationModel)
self.isolated_local_models = [CharModel, RelationModel]
constraints = self.get_constraints_for_column(
CharModel, CharModel._meta.get_field("field").column
)
self.assertIn("schema_charmodel_field_8b338dea_like", constraints)
self.assertIn(
"varchar_pattern_ops",
self.get_constraint_opclasses("schema_charmodel_field_8b338dea_like"),
)
rel_constraints = self.get_constraints_for_column(
RelationModel, RelationModel._meta.get_field("field").column
)
self.assertIn("schema_relationmodel_field_id_395fbb08_like", rel_constraints)
self.assertIn(
"varchar_pattern_ops",
self.get_constraint_opclasses(
"schema_relationmodel_field_id_395fbb08_like"
),
)
self.assertEqual(
self.get_column_collation(RelationModel._meta.db_table, "field_id"),
deterministic_collation,
)
self.assertEqual(
self.get_column_collation(CharModel._meta.db_table, "field"),
deterministic_collation,
)
self.assertIn("field_id", self.get_uniques(RelationModel._meta.db_table))
def test_alter_textfield_to_null(self):
"""
#24307 - Should skip an alter statement on databases with