mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-22 17:16:24 +00:00
Code Issues 25 Releases Wiki Activity

Fixed #33406 -- Avoided creation of MaxLengthValidator(None) when resolving Value.output_field for strings.

Browse Source 
This brings the behaviour in line with Field subclasses which append to
the validators within __init__(), like BinaryField, and prevents the
creation of a validator which incorrectly throws a TypeError, if it
were used.
This commit is contained in:
Keryn Knight 2022-01-03 11:29:24 +00:00 committed by Mariusz Felisiak
parent b894199eb0
commit 0ed2919814
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
django/db/models/fields/__init__.py
View File

@ -1010,7 +1010,8 @@ class CharField(Field):
def __init__(self, *args, db_collation=None, **kwargs): def __init__(self, *args, db_collation=None, **kwargs):
super().__init__(*args, **kwargs) super().__init__(*args, **kwargs)
self.db_collation = db_collation self.db_collation = db_collation
self.validators.append(validators.MaxLengthValidator(self.max_length)) if self.max_length is not None:
self.validators.append(validators.MaxLengthValidator(self.max_length))
def check(self, **kwargs): def check(self, **kwargs):
databases = kwargs.get('databases') or [] databases = kwargs.get('databases') or []

1
tests/expressions/tests.py
View File

@ -1859,6 +1859,7 @@ class ValueTests(TestCase):
and this demonstrates that they don't throw an exception. and this demonstrates that they don't throw an exception.
""" """
value_types = [ value_types = [
'str',
True, True,
42, 42,
3.14, 3.14,