From 0ebb02e9dc2ea9906e2db36dc3f7d998231d462f Mon Sep 17 00:00:00 2001 From: Luke Plant Date: Thu, 13 Jan 2011 23:25:23 +0000 Subject: [PATCH] [1.2.X] Fixed some bugs with formtools tests. Without these checks, it is possible for the tests to pass by virtue of asserts never being reached for some reason (very possible in this case, due to handling of security hashes). Backport of [15198] from trunk. git-svn-id: http://code.djangoproject.com/svn/django/branches/releases/1.2.X@15200 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- django/contrib/formtools/tests.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/django/contrib/formtools/tests.py b/django/contrib/formtools/tests.py index 264c732598..de71fe5443 100644 --- a/django/contrib/formtools/tests.py +++ b/django/contrib/formtools/tests.py @@ -247,6 +247,7 @@ class WizardTests(TestCase): Regression test for ticket #15075. Allow modifying wizard's form_list in process_step. """ + reached = [False] that = self class WizardWithProcessStep(WizardClass): @@ -255,6 +256,7 @@ class WizardTests(TestCase): self.form_list[1] = WizardPageTwoAlternativeForm if step == 1: that.assertTrue(isinstance(form, WizardPageTwoAlternativeForm)) + reached[0] = True wizard = WizardWithProcessStep([WizardPageOneForm, WizardPageTwoForm, @@ -264,3 +266,4 @@ class WizardTests(TestCase): "hash_0": "2fdbefd4c0cad51509478fbacddf8b13", "wizard_step": "1"} wizard(DummyRequest(POST=data)) + self.assertTrue(reached[0])