From 0d7b6884df5efc6c9eafc8a81f39ccfb8bc931f5 Mon Sep 17 00:00:00 2001 From: Malcolm Tredinnick Date: Mon, 3 Dec 2007 21:23:15 +0000 Subject: [PATCH] queryset-refactor: Added a FIXME for something I just remembered. git-svn-id: http://code.djangoproject.com/svn/django/branches/queryset-refactor@6869 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- django/db/models/sql/query.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/django/db/models/sql/query.py b/django/db/models/sql/query.py index ad78c4dd47..d7317059e3 100644 --- a/django/db/models/sql/query.py +++ b/django/db/models/sql/query.py @@ -738,6 +738,10 @@ class Query(object): table = table_it.next() if join == table and self.alias_map[join][ALIAS_REFCOUNT] > 1: continue + # FIXME: Don't have to promote here (and in the other places in + # this block) if the join isn't nullable. So I should be + # checking this before promoting (avoiding left outer joins is + # important). self.promote_alias(join) if table != join: self.promote_alias(table)