mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-24 06:06:09 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #30604 -- Made mail_admins()/mail_managers() raise ValueError if ADMINS/MANAGERS is set incorrectly.

Browse Source
This commit is contained in:
Hasan Ramezani
2019-06-29 01:50:43 +02:00
committed by Mariusz Felisiak
parent 29240a9952
commit 090ca6512f
3 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/mail/tests.py
View File

@@ -991,6 +991,23 @@ class BaseEmailBackendTests(HeadersCheckMixin):
mail_managers('hi', 'there')
self.assertEqual(self.get_mailbox_content(), [])
def test_wrong_admins_managers(self):
tests = (
'test@example.com',
('test@example.com',),
['test@example.com', 'other@example.com'],
('test@example.com', 'other@example.com'),
)
for setting, mail_func in (
('ADMINS', mail_admins),
('MANAGERS', mail_managers),
):
msg = 'The %s setting must be a list of 2-tuples.' % setting
for value in tests:
with self.subTest(setting=setting, value=value), self.settings(**{setting: value}):
with self.assertRaisesMessage(ValueError, msg):
mail_func('subject', 'content')
def test_message_cc_header(self):
"""
Regression test for #7722