mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-24 06:06:09 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #33096 -- Fixed <form> nesting in technical 500 template.

Browse Source 
This also prevents sending <form> tags in emails.
This commit is contained in:
Jan Schär
2021-09-07 22:50:29 +02:00
committed by Mariusz Felisiak
parent 0a28b42b15
commit 06e59d97a3
2 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/logging_tests/tests.py
View File

@@ -422,6 +422,22 @@ class AdminEmailHandlerTest(SimpleTestCase):
msg = mail.outbox[0]
self.assertEqual(msg.body, 'message\n\ncustom traceback text')
@override_settings(ADMINS=[('admin', 'admin@example.com')])
def test_emit_no_form_tag(self):
"""HTML email doesn't contain forms."""
handler = AdminEmailHandler(include_html=True)
record = self.logger.makeRecord(
'name', logging.ERROR, 'function', 'lno', 'message', None, None,
)
handler.emit(record)
self.assertEqual(len(mail.outbox), 1)
msg = mail.outbox[0]
self.assertEqual(msg.subject, '[Django] ERROR: message')
self.assertEqual(len(msg.alternatives), 1)
body_html = str(msg.alternatives[0][0])
self.assertIn('<div id="traceback">', body_html)
self.assertNotIn('<form', body_html)
class SettingsConfigTest(AdminScriptTestCase):
"""